SuffolkLITLab / docassemble-ALKilnSetup

A docassemble extension for testing the AssemblyLine automated integrated testing framework.
MIT License
1 stars 2 forks source link

Setup: Correct the number of SECRETS being stored or describe the number of SECRETS dynamically #168

Closed plocket closed 2 years ago

plocket commented 2 years ago

For now, we can just edit to correct this to 4 secrets. In future, can we use a variable to count the number of secrets? We'll need to store them in a list or something.

Feedback

on the page next steps, you've got the code for:

  % if secrets_need == 'org' or secrets_need == 'repo':
  3 [GitHub secrets](https://docs.github.com/en/actions/reference/encrypted-secrets) were set to store {encrypted docassemble login information} safely:

  ${ secrets_list }
  % endif

for me this rendered as:

3 GitHub secrets were set to store encrypted docassemble login information safely:
* PLAYGROUND_EMAIL
* PLAYGROUND_PASSWORD
* PLAYGROUND_ID
* SERVER_URL

that's clearly 4 secrets, not 3

plocket commented 2 years ago

Closed by PR #178