SuffolkLITLab / docassemble-ALKilnSetup

A docassemble extension for testing the AssemblyLine automated integrated testing framework.
MIT License
1 stars 2 forks source link

Clarify overriding previous secrets #205

Open plocket opened 1 year ago

plocket commented 1 year ago

From the relevant code block, it looks like we only make or override org secrets if they are an admin. So it doesn't make sense to ask specifically about org secrets if they aren't an admin, because the next question is asking if they want to override those secrets. The implicit question is "has someone already setup org secrets? -> if they haven't, go ask them to, if they have, you can't override them, so just keep going", but that adds a decent bit of complexity.

Regarding https://github.com/plocket/docassemble-ALAutomatedTestingTests/pull/200#discussion_r1025434491 and

https://github.com/plocket/docassemble-ALAutomatedTestingTests/blob/f2aa2ab12af5583e0b63b3cc87122452a50638ed/docassemble/ALAutomatedTestingTests/data/questions/al_set_up_testing.yml#L206-L225

Suggested update:

  - label: |
      % if is_org_admin:
      Has someone already set up the repository or organization secrets?
      % else:
      Has someone already set up the repository's secrets?
      % endif
    field: already_has_secrets
    datatype: yesnoradio
plocket commented 1 year ago

I think this doesn't quite work. If the user is not an org admin, that doesn't mean there aren't organization secrets. Maybe we need to ask a totally different set of questions. We'll have to brainstorm about that.

Brainstorm 1

If isn't org admin:

Also, the first question needs to be different - if they're not part of an org, don't mention org secrets.

Brainstorm 2


I think that's the only brainstorming I have for now.