Do we need "action title" screen?

[purplesky2016]

This screen has one input field interview_intro_prompt, its default value is calculated based on form_type and the result is set to interview_intro_prompt (used to be short_title) in the generated interview. The screen text is confusing.

If most people don't really customize its value on this screen, we can keep the code to set the default value and remove the screen, which will improve the screen flow of the Weaver.

See Weaver input/output flowchart.

[nonprofittechy]

Discussion on 3/30/21 standup:

We do want to keep it. We want to re-phrase it to "Call to action" and provide clearer instructions and perhaps a visual.

[purplesky2016]

In that case, maybe we should consider combine it with "Your specific form’s intro screen" as Quinten pointed out on Monday. Part of the confusion comes from the fact that interview_intro_prompt is really the title of that screen, yet it's on a separate screen and comes up afterwards; more importantly, interview.form_type comes before the into screen which is backward in terms of the natural flow. It seems to me that this whole situation occurred due to some technical difficulty associated with this separate screen.

To restore the natural flow and reduce confusion yet still keep the original intent, we can combine these two screens and move it upward, then make "call to action" a focal point of the combined screen to emphasize it.

[purplesky2016]

Now I understand this is for the branding screen not the intro screen, so I'll keep it but move it to be before the intro screen for the specific form, because that's the nature flow. Will add a visual.

[purplesky2016]

[purplesky2016]

The image shadow rule is added to progressivedisclosure.css. Should I change the file name to be styles.css for general purpose or add a new css file instead?

[plocket]

I suspect we want just one css file. If that's the case, I think changing to styles.css is a good idea. After making it and pushing it, you'll need to come to github to delete the old progressivedisclosure.css.

[nonprofittechy]

It would be fine to rename the CSS file and add the new lines there. Just leave in some comments to clarify what CSS is for what.

I added the progressive disclosure functionality to ALToolbox: https://github.com/SuffolkLITLab/docassemble-ALToolbox/blob/master/docassemble/ALToolbox/data/questions/collapse_template.yml so we should eventually delete that CSS and migrate the collapsible elements to use that newer code. I don't care if we do that now or later though--whichever is easier.

See #433

[purplesky2016]

Okay, I'll rename the css.

Also here is a new visual for branding_extra, I moved the brand name to the front, I think that would be more natural. What do you think?

[purplesky2016]

As discussed, I will use the old image for now until the idea is discussed with a larger group.

[purplesky2016]

@nonprofittechy - In order to test the logo in the Weaver, I had to install my package with the new package name ALWeaver on my server, which effectively erased the old package name assemblylinewizard and its pointer to my branch "screen-reordering".

Now I am ready to push the code, but even though I renamed the package back to the old name, I still can't push to my branch, got an error:

create_playground_package: error running git merge --squash playgroundEGzyf.  Doing GIT_SSH=/tmp/datemp_0uak04k.sh git clone git@github.com:SuffolkLITLab/docassemble-assemblylinewizard.git
Cloning into 'docassemble-assemblylinewizard'...
Warning: Permanently added 'github.com,140.82.112.3' (RSA) to the list of known hosts.
Doing git checkout df65356554ea5459ae02aecca14400817b3e24e0
Note: checking out 'df65356554ea5459ae02aecca14400817b3e24e0'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again.

Should I start a new branch and push my code, then compare with screen-reordering?

[nonprofittechy]

That specific error usually just happens when there is no change in the code

On Wed, Jun 2, 2021, 2:17 PM purplesky2016 @.***> wrote:

In order to test the logo in the Weaver, I had to install my package with the new package name ALWeaver on my server, which effectively erased the old package name assemblylinewizard and its pointer to my branch "screen-reordering".

Now I am ready to push the code, but even though I renamed the package back to the old name, I still can't push to my branch, got an error:

create_playground_package: error running git merge --squash playgroundEGzyf. Doing GIT_SSH=/tmp/datemp_0uak04k.sh git clone @.***:SuffolkLITLab/docassemble-assemblylinewizard.git

Cloning into 'docassemble-assemblylinewizard'...

Warning: Permanently added 'github.com,140.82.112.3' (RSA) to the list of known hosts.

Doing git checkout df65356554ea5459ae02aecca14400817b3e24e0

Note: checking out 'df65356554ea5459ae02aecca14400817b3e24e0'.

You are in 'detached HEAD' state. You can look around, make experimental

changes and commit them, and you can discard any commits you make in this

state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may

do so (now or later) by using -b with the checkout command again.

Should I start a new branch and push my code, then compare with screen-reordering?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SuffolkLITLab/docassemble-assemblylinewizard/issues/319#issuecomment-853276215, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2KTSOKAM35NL7MEKSMBODTQZYSDANCNFSM42ACOWHQ .

[purplesky2016]

There are code changes, as you can see in https://github.com/SuffolkLITLab/docassemble-assemblylinewizard/commit/844199206e4021cb6a1ad455baa5b7da48ad5ec9. I just can't push them to the right branch.

[purplesky2016]

I've tried to push it to a new branch a few times and compared with "screen-reordering", but now it listed many commits than I recognize.

I guess the cleanest way is probably merge pull request #426, so I can check out the latest master and add these changes to that, then push them to a new branch.

[nonprofittechy]

Do you want to just upload that missing PNG as an attachment here? Then I will add a commit and merge #426

[purplesky2016]

I wish I could. I got the error listed above (a hour ago) when I tried to push to that branch.

[purplesky2016]

It's all because I changed the package name when I tested the logo, which put my project in 'detached HEAD' state.

[purplesky2016]

All my changes are in https://github.com/SuffolkLITLab/docassemble-assemblylinewizard/commit/844199206e4021cb6a1ad455baa5b7da48ad5ec9. If you can manage to get them in from your playground that should suffice.

Do you need me attach the png and styles.css files here?

[nonprofittechy]

OK I will handle the merge.

[purplesky2016]