search

SuffolkLITLab / docassemble-ALWeaver

A tool to help quickly generate draft interviews from an existing document (pdf or DOCX) for the docassemble platform.
https://apps-test.suffolklitlab.org/start/ALWeaver/assembly_line/#/1
MIT License
19 stars 6 forks source link

"Edit" on a review table row shouldn't trigger all columns #482

Open nonprofittechy opened 3 years ago

BryceStevenWilley commented 3 years ago

We already do something similar I think: https://github.com/SuffolkLITLab/docassemble-ALWeaver/blob/38325e1d62bfb9c75ad0492ce594c6e6ecf56311/docassemble/ALWeaver/interview_generator.py#L604.

Updating to showifdef would be shorter, but doesn't change any functionality.

In the teams discussion this issue is based on, it looks like the issue is that docassemble will trigger screens for all of the columns in the table, and we don't seem to have a way to disable that for specific columns. Either way, that seems out of scope for the Weaver.

nonprofittechy commented 3 years ago

Docassemble definitely won't trigger screens for all columns in the table--you can have as many columns as you want and they don't need to correspond to a specific attribute of the object in the list. But it does seem something else must be going on here. I agree no reason to switch from if defined to showifdef, they're the same thing.

nonprofittechy commented 3 years ago

One quick guess is that we have something in the .complete attribute, but I haven't checked yet. Noting it here for later.

BryceStevenWilley commented 3 years ago

Discussed at deep dive, we're not sure if this is we want / if we can do this in the Weaver side

nonprofittechy commented 3 years ago

Discussed at deep dive, we're not sure if this is we want / if we can do this in the Weaver side

Sounds fair enough, but can we confirm the behavior of a newly weaved form? My feeling is that the review screen should never force the definition of a variable. I haven't reproduced the issue yet to know what we're deciding to do or not do.

plocket commented 2 years ago

Does this replicate the issue?

https://user-images.githubusercontent.com/52798256/148407832-3da3b3de-340c-43a8-9111-551803a5d685.mp4