search

SuffolkLITLab / docassemble-ALWeaver

A tool to help quickly generate draft interviews from an existing document (pdf or DOCX) for the docassemble platform.
https://apps-test.suffolklitlab.org/start/ALWeaver/assembly_line/#/1
MIT License
19 stars 5 forks source link

Create filenames with the party names by default #894

Open nonprofittechy opened 9 months ago

nonprofittechy commented 9 months ago

If the users and other_parties objects are created, we should default to making the filename include the names of the parties. This both gives an example in the output for this common customization and makes it easier to track tests.

@plocket I do wonder if this breaks the expectations of any tests, that the filename may vary from run to run.

plocket commented 9 months ago

It might. That code was meant to be flexible enough to handle this kind of thing, but we've had some trouble with it. Thanks for the heads up.

Do you foresee a situation in which the developer would create multiple files that share a part of their name? For example something like "sam_letter.pdf" and "pat_letter.pdf". Or is that not something that would come up?

nonprofittechy commented 9 months ago

Maybe, but likely we'd prepend the party names to the name of the file. Generally that would be as unique as it is now.

plocket commented 9 months ago

It would be unique enough for devs and users, but not for ALKiln to recognize as it currently is. I'm sure we can account for that by checking for overall uniqueness (discounting the ID of course). Thanks, good to know.