SuffolkLITLab / docassemble-AssemblyLine

Quickly go from a paper court form to a runnable, guided, step-by-step web application powered by Docassemble. Swap out branding and pre-built questions to meet your needs.
https://suffolklitlab.org/docassemble-AssemblyLine-documentation/
MIT License
41 stars 5 forks source link

Check SMS is enabled before showing texting opts #803

Closed BryceStevenWilley closed 9 months ago

BryceStevenWilley commented 9 months ago

The only change I could see being suggested is to move is_sms_enabled() (and is_phone_or_email(), even thought it's been in AL for a while) to the Toolbox. IMO, it's not worth splitting highly coupled functions between two different packages, but will happily do it if suggested.

Fixes #411 for texting, not for email, but as mentioned in the meeting this morning, most of our users have some sort of email enabled on their server.

BryceStevenWilley commented 9 months ago

If we do make that change, we should use proper syntax - <br/> not <br>

I'm fine with changing it, but from what I understand, <br> is fine, <br/> is only necessary for XHTML