SuffolkLITLab / docassemble-InterviewStats

A docassemble extension.
MIT License
1 stars 0 forks source link

Don't display `auto_title` in interview stats #20

Closed nonprofittechy closed 1 year ago

nonprofittechy commented 1 year ago

Fix #19

auto_title in AssemblyLine interviews defaults to containing the user's name, which is contrary to the purpose of anonymous interview statistics.

nonprofittechy commented 1 year ago

From what I can tell, this change needs to happen downstream, not in this package. For my own clarification, since I had to look it up, auto_title is one of the automatically saved pieces of info in AL now, related to the interview list and sessions. It isn't in directly defined in any variable that I can see, but it is a part of the interview metadata, unencrypted.

My main opposition is that the only generally anonymous things should be saved in the first place. store_variables_snapshot only saves the things you pass it, and based on the package you linked this to, on feedback you don't pass any specific variables, so it stores everything, which is probably the info this is picking up.

Feedback.yml is its own session. We do have an explicit and very short list of data being saved by the actual interview:

https://github.com/nonprofittechy/docassemble-HousingCodeChecklist/blob/35f997acd056bdbf4b325d9b2c4f76272dd0cfa8/docassemble/HousingCodeChecklist/data/questions/housing_code_interview.yml#L529

auto_title is not on that list.

IMO, you just shouldn't save everything there if you don't want it to be displayed. If interview metadata is now being stored by default by docassemble and there's no easy way around it, I'm happy to merge, but we should consider an alternative to store_variables_snapshot, since we don't want to store that extra information.