Closed BryceStevenWilley closed 1 year ago
Was added for some reason in https://github.com/SuffolkLITLab/docassemble-InterviewStats/commit/33234abd2112dcf73ebd594b1530ad79bd241a05, my only guess as to why is that we needed to display the user defined tags, and docassemble internally calls that a key. So likely the first implementation tried to get the key from the JSON table, but it was the wrong value, and was never removed?
Should be able to remove it without harm, but TBH it's concerning that the session id is just there. Would be nice to patch upstream to be the hash, which seems like the best alternative.
Was added for some reason in https://github.com/SuffolkLITLab/docassemble-InterviewStats/commit/33234abd2112dcf73ebd594b1530ad79bd241a05, my only guess as to why is that we needed to display the user defined tags, and docassemble internally calls that a key. So likely the first implementation tried to get the key from the JSON table, but it was the wrong value, and was never removed?
Should be able to remove it without harm, but TBH it's concerning that the session id is just there. Would be nice to patch upstream to be the hash, which seems like the best alternative.