search

SuffolkLITLab / docassemble-InterviewStats

A docassemble extension.
MIT License
1 stars 0 forks source link

ExcelWriter doesn't take an options argument #24

Closed BryceStevenWilley closed 1 year ago

BryceStevenWilley commented 1 year ago 
File "/usr/share/docassemble/local3.10/lib/python3.10/site-packages/docassemble/base/parse.py", line 9835, in exec_with_trap     exec(the_question.compute, the_dict)   File "<code block>", line 11, in <module> TypeError: ExcelWriter.__new__() got an unexpected keyword argument 'options'

https://github.com/SuffolkLITLab/docassemble-InterviewStats/blame/c42376b1cdb7f05a4a89c76c06c68dd4edf5c016/docassemble/InterviewStats/data/questions/subscribe.yml#L88

nonprofittechy commented 1 year ago

I saw this on Slack (Michael from Legal Server raised it). I think it's a bug fixed in the latest DA.

https://docassemble.slack.com/archives/C7791ATUJ/p1691467552145919

nonprofittechy commented 1 year ago

PR was merged: https://github.com/jhpyle/docassemble/pull/675

I guess we need to replicate the change, change options to engine_kwargs

BryceStevenWilley commented 1 year ago

Gotcha, we have that code copy pasted in this repo, but that does look like the correct fix.

nonprofittechy commented 1 year ago

Maybe in a try/except, I hate fixing code for latest but breaking it on non-bleeding edge installs.

BryceStevenWilley commented 1 year ago

That would be fair. That new argument and other deprecation was made in pandas 1.3.0, and Docassemble has used pandas > 1.3.0 since April 2022. Try except isn't too bad though.

nonprofittechy commented 1 year ago

A year to upgrade is fine, I take back my suggestion