search

SuffolkLITLab / docassemble-MAVirtualCourt

Project which currently holds code for the Doc Assembly Line project, including dependencies for actual interviews.
Other
7 stars 5 forks source link

Testing: Should link tests actually click links? #613

Closed plocket closed 3 years ago

plocket commented 4 years ago

Should this be clicking on the link? Right now, I think it's just checking whether the link opens in a new window or not.

_Originally posted by @niharikasingh in https://github.com/SuffolkLITLab/docassemble-MAVirtualCourt/pull/597#discussion_r482633920_

plocket commented 4 years ago

Response:

There was some complication involved in clicking on the link. I don't remember what. Maybe it was that some buttons, like the escape button, won't open a new window - just change the current one, so I didn't want links in general to actually be clicked on. Maybe it was something else? Maybe I had trouble detecting a new window opening with puppeteer?

To sum up, it is deliberately not clicking on the link, though it might be worth discussing alternatives. Perhaps for a future issue? (I only mention making issues because if this is pulled in, other development can happen at the same time as this is being improved.)