search

Sukhrobjon / TipCalculatorWeb

FEW-1.1 Class challenge
0 stars 0 forks source link

Looks good #1

Open soggybag opened 5 years ago

soggybag commented 5 years ago

This looks good. Everything is working well. The styles are pretty close the images.

I notice when the amount is 0 or the number of people is 0 the results at the bottom show NaN (Not a Number) or infinity. This makes sense to us, but people using your app might be confused.

Challenge: Can you check for these situations and show a reasonable result if the amount or the number of people is not within expected ranges?

Stretch Challenge: Currently everything is working fine but maybe it can work even better. Notice that you always must press the calculate button to see the results. What if you used the onchange or oninput you can update the results as values are entered into the fields.

Sukhrobjon commented 5 years ago

Thank you for your feedback Mitchel, I will keep working on that to improve it.