search

SukkaW / DisqusJS

:speech_balloon: Render Disqus comments in Mainland China using Disqus API
https://disqusjs.skk.moe
MIT License
650 stars 56 forks source link

Replace spread operator with Array.from; use encodeURIComponent before GET #51

Closed renzibei closed 4 years ago

renzibei commented 4 years ago
  1. Use spread operator (e.g. [...aTag]) with gulp together will cause unexpected behavior because gulp will replace [...aTag] with [].concat(aTag), which is not expected as aTag can be a HTMLCollection. This will cause bug in my computer. (gulp-cli@2.3.0)
  2. As is mentioned in #50 Encode the parameters of GET method first because different browsers on different operating systems will use different ways to encode unicode chars in GET parameters (especially IE).
renzibei commented 4 years ago

LGTM.

You are really fast. 🐶