search

SukkaW / nolyfill

Speed up your package installation process, reduce your disk usage, and extend the lifespan of your precious SSD.
MIT License
1.11k stars 15 forks source link

Replace qs #70

Closed gkiely closed 5 months ago

gkiely commented 5 months ago

Imports 14 dependencies https://npm.anvaka.com/#/view/2d/qs https://github.com/ljharb/qs/issues/404

mikkurogue commented 5 months ago

All 14 dependencies are also authored by our friend lol...

I'll see if I can find some time to find a replacement and do my part in cleaning.

SukkaW commented 5 months ago

Actually, we don't have to replace the entire qs.

https://npmgraph.js.org/?q=qs

image

As you can see, the toxic dependency is the side-channel that brings all its friends.

And nolyfill already handles side-channel by providing @nolyfill/side-channel: https://github.com/SukkaW/nolyfill/tree/93c7c4aace6d8e51b4c734f4d6d84fe9d0df8a2b/packages/generated/side-channel

@mikkurogue This info should help you if you want to submit a PR to qs or create a fork!

I am going to close the issue since we already have @nolyfill/side-channel. But if qs introduce any other new toxic dependencies, feel free to create a new issue or ping me to re-open this one!