search

Sukkaito / pe

0 stars 0 forks source link

bugs: `find` command not working with capitalize course code #8

Open Sukkaito opened 2 weeks ago

Sukkaito commented 2 weeks ago

If the course code in the savefile is capitalize, it will not be recognize

Step to reproduce:

Expected behavior:

Actual behavior:

Screenshot:

image.png

soc-se-bot commented 1 week ago

Team's Response

Thank you for the feedback! We would check for cases in the data file properly in the next iteration.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

bugs: Some commands still works when savefile contains the same entries

Commands will work if you have the same entries for the same mapping. This could cause inconvenience when user has a lot of mapping, making it difficult to manually remove them.

Step to reproduce:

  • Make sure the save file have some entries refer to the same mapping but different cases (e.g. cs3243 | the university of western australia | CITS3001 and cs3243 | the university of western australia | cits3001). Notice the difference in UWA's course name.
  • Run any command (e.g. compare pu/uwa pu/anu or list mapped) ,works normally with duplicated entries

Expected behavior:

  • Remove duplicated entries.

Actual behavior:

  • All duplicated entries are shown

Screenshots:

image.png

[original: nus-cs2113-AY2425S1/pe-interim#740] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for the feedback! We would check for cases in the data file properly in the next iteration.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Sorry for the confusion, due to the limited time of the PE session, I didn't have enough time to elaborate my concern about why this should be a separated bug rather than a similar bug to #446.

Originally, when I tested the find command, it worked but only with non-capitalized course code, rather than BOTH non-capitalize and capitalize course codes like the examples in the aforementioned issue, thus this indicates there will be some work that needs to be done with the find command (or the rest of the commands) as well.

For reference, here's a screenshot of the find command using the save file with both non-capitalize and capitalize course codes: image.png

(Notice the difference in results for course code "CS3243", in the aforementioned issue, all the course codes were displayed, while only the non-capitalize course code was displayed when using the find command)

## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Since this `find` command is an important feature from all the way back to v1.0, I think that this issue should deserve a `severity.Medium` instead, considering how much impact it has on the whole user experience.