search

SukkoPera / OpenFlops

Open-Hardware Floppy Drive Simulator
Other
270 stars 40 forks source link

OpenFlops SD Card revisions #18

Closed COREi64 closed 3 weeks ago

COREi64 commented 1 year ago

Hi. Forgive me if I've not done this right.

This is the first time I've collaborated on a github and am not sure if my changes will come across to you. If not, please do reach out to me, you have my e-mail address (info@corei64.com).

Thanks, Thomas

SukkoPera commented 1 year ago

There are a number of things to fix before this PR can be merged:

  1. Please delete the gerbers.SD-MAX.FINAL folder.
  2. Please delete the _autosave-OpenFlops.sch file.
  3. Since you migrated the project to Kicad 6, some leftover files from Kicad 5 should be removed, which includes the OpenFlops.pro and OpenFlops.sch files at least.
  4. The schematics have several issues too, I suggest using the Electrical Rules Check button and fix all the errors it reports, as some are severe.
  5. Apparently you didn't include the updated _OpenFlops.kicadpcb file in the PR :).
SukkoPera commented 1 year ago

I have slightly polished the design and removed as many ERC/DRC errors as I could.

Nevertheless, I have decided to keep this PR open for the moment, as I absolutely hate KiCad 6 (this PR migrated the whole design to that) and do not feel confident on what I have done, besides not being able to align/route some things as I would have liked.

Thanks for your contribution anyway, it's not going to be lost.

SukkoPera commented 3 weeks ago

Obsoleted by #21, merged in branch devel.