search

SukkoPera / PsxNewLib

Playstation controller interface library for Arduino
GNU General Public License v3.0
130 stars 28 forks source link

SCPH-1150 rumble #23

Open sonik-br opened 1 year ago

sonik-br commented 1 year ago

Hi!

The japanese SCPH-1150 dual analog controller features a primitive type of rumble. It uses single motor with only on/off state and does not support any kind of configuration command. So no need to "enable rumble".

I don't have access to this model of controller but the DualShock is backward compatible with this old rumble mode. I've added support for this type of rumble and it's working with a DualShock. I can submit a PR with the code change.

BTW I've also added support for the jogcon's motors long ago. Been using it for years now. Should I submit a PR for it too? I would ask you to take a look if you see a better way to implement it and to fit the lib's coding style.

SukkoPera commented 1 year ago

Hi, yes, feel free to submit PRs for everything! I'd really like to keep a single library with all the features rather then having a number of different, incompatible libraries. I am not working on this at the moment, but I promise I'll merge everything, one day :).

Just submit several PRs if you can though, one for every feature. This would help a lot.

sonik-br commented 1 year ago

Cool. Will do. Might be complex to do multiple PRs but I will try. Both features need to change how the rumble command works.

SukkoPera commented 1 year ago

Well, one will be fine too then!

sonik-br commented 1 year ago

Got it in multiple PRs. :)