search

Sukrut1881 / pe

0 stars 0 forks source link

Documentation not correct for add command 's priority feature #5

Open Sukrut1881 opened 4 years ago

Sukrut1881 commented 4 years ago

image.png

vs

image.png

priority can be entered as any value and exception is not caught. This allows me to input any priority while still creating a task with low priority as default

nus-pe-bot commented 4 years ago

Team's Response

There's actually a message saying "There seems to some mistake in your priority entry, will be setting priority as low" when you enter invalid priority. It's just that we haven't wrapped that message between 2 lines for better visibility.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Default values should only be kept when no priority is entered, not when an invalid value is entered. Use of Enumerations here would help in weeding out improper inputs.

:question: Issue severity

Team chose [severity.Low]. Originally [severity.High].

Reason for disagreement: [replace this with your reason]

:question: Issue type

Team chose [type.FeatureFlaw]. Originally [type.DocumentationBug].

Reason for disagreement: [replace this with your reason]