SumOfUs / sumofus

0 stars 0 forks source link

Images and campaign pages #17

Open NealJMD opened 9 years ago

NealJMD commented 9 years ago

Looking at the campaign pages which you can see here, I'm realizing we need to change how we're handling images on campaign pages. Currently we upload as many images as you want through dropzone, and it sticks them all in a slideshow.

We have a couple of other needs -

I think it'll be pretty straightforward to add a metadata form for each uploaded image, but I'm pretty unsure how to go about adding the images inline in the WYSIWYG under our current scheme. @osahyoun you mentioned before you had a plan, is that still true?

paulaferris commented 9 years ago

Inline images: I'd say that I think it's probably fine to come back to images in the body text at a later point. It's likely not an MVP feature we need (and I assume if we urgently did we could hack it by just upload the image manually to an S3 account or elsewhere and coding in the HTML manually). That said, having a plan sounds fine :) Just don't think we need to prioritize this highly given it likely won't be needed in the 90% use case.

Re images more broadly: Are the images optimized/compressed/cropped at all in the current setup? I think not, which is again fine for now, but we should think about how to handle this going forward given that will effect both campaigner workflow (i.e. make it easier) and page load speed significantly.

osahyoun commented 9 years ago

@paulaferris images are being processed on upload - we create a variety of sizes, for different use cases. We also store the primary (raw) image, and so have the flexibility of creating new sizes/crops at a later time.

osahyoun commented 9 years ago

@NealJMD for dropping images into the quill editor: http://quilljs.com/docs/api/#quillprototypeinsertembed