Summer-16 / CSGO-VMPanel

A Fully automated VIP Management panel for CSGO Community servers
GNU General Public License v3.0
86 stars 19 forks source link

Public IP not getting properly by Plugin #26

Open TandelK opened 3 years ago

TandelK commented 3 years ago

Describe the bug When using new Plugin , the Server is automatically added but the IP address it takes is not of Public IP but taking Internal IP of the Network. This happens with all major Hosting like Amazon AWS, DigitalOcean and other providers.

To Reproduce Steps to reproduce the behavior:

  1. Install New Plugin on Server and connect it to Database
  2. Open Panel and check the new server has been added to the list.
  3. Go to Modify Server Information and check the IP address displayed.

Expected behavior Should return proper Public IP address otherwise RCON wont work.

Summer-16 commented 3 years ago

Plugin takes the value of CVAR named "hostip" from CSGO Server. Which I found to be the best way of getting the IP of server and in most of the cases it is the public IP of server, until it is been overwritten manually for machines in which multiple IP is available.

If you happen to know a more solid way of getting Public IP of server please let me know. I will update in next version.

TandelK commented 3 years ago

@Summer-16 The only solution i had known before was to use the same hostip method but use it with converted tool here into numbers as i had discussed same with CallAdmin Plugin Developer.

https://github.com/Impact123/CallAdmin/issues/28

Summer-16 commented 3 years ago

Thanks for reference, I will try to fix it in next version.