SumoLogic / fluentd-output-sumologic

Fluentd output plugin to deliver logs or metrics to Sumo Logic.
https://rubygems.org/gems/fluent-plugin-sumologic_output
Apache License 2.0
29 stars 28 forks source link

1.4.1 broke parameter expansion of `${tag_parts[1]}` #47

Closed taraspos closed 5 years ago

taraspos commented 5 years ago

Hello. I'm using the plugin with next configuration:

<match {app,ecs}.**>
 @type           sumologic
 endpoint        "#{ENV["SUMOLOGIC_ENDPOINT"]}"
 log_format      json
 source_category "#{ENV["SUMOLOGIC_SOURCE_CATEGORY"]}"
 source_name     ${tag_parts[1]} # use second part of the tag as source_name
 open_timeout    300
</match>

Yesterday I upgraded to the v1.4.1 and placeholder expansion for ${tag_parts[1]} stopped working. PR #40 broke it, now ${tag[1]} has to be used. Not a big problem for me, but I think you should mention somewhere that this is breaking change.

bin3377 commented 5 years ago

Thanks for the reporting! Will take a look if we need a fix or an update of document

bin3377 commented 5 years ago

https://github.com/SumoLogic/fluentd-output-sumologic/pull/48

taraspos commented 5 years ago

@bin3377 thanks! What do you think about mentioning this breaking change in the CHANGELOG.md? Entry for the v1.4.1 completely missing there.

bin3377 commented 5 years ago

updated. But consider we are moving the release to be fully managed by TravisCI. I may consider remove the CHANGELOG.md later (since it's duplicated with the release note) or somehow make it automatically updated.

asafpelegcodes commented 5 years ago

I didn't understand the outcome from this?

Is this something that is going to be fixed or is it an intended change? @bin3377

asafpelegcodes commented 5 years ago

NVM I figured it out, thanks