search

SumoLogic / sumologic-aws-lambda

A collection of lambda functions to collect data from Cloudwatch, Kinesis, VPC Flow logs, S3, security-hub and AWS Inspector
Other
152 stars 134 forks source link

Linting CloudFormation templates would make them simpler #164

Open volphy opened 1 year ago

volphy commented 1 year ago

Have you considered using AWS CloudFormation linter https://github.com/aws-cloudformation/cfn-lint against the CloudFormation templates in this repository:

in order to improve them?

volphy commented 1 year ago

Example warnings (cfn-lint 0.76.2):

$ cfn-lint DLQLambdaCloudFormation.yaml 
W2001 Parameter environment not used.
DLQLambdaCloudFormation.yaml:11:3

W3005 Obsolete DependsOn on resource (SumoCWLogGroup), dependency already enforced by a "Ref" at Resources/SumoCWLogSubscriptionFilter/Properties/LogGroupName/Ref
DLQLambdaCloudFormation.yaml:91:9

W3005 Obsolete DependsOn on resource (SumoCWLogsLambda), dependency already enforced by a "Fn:GetAtt" at Resources/SumoCWLogSubscriptionFilter/Properties/DestinationArn/Fn::GetAtt
DLQLambdaCloudFormation.yaml:93:9

W3005 Obsolete DependsOn on resource (SumoCWLambdaExecutionRole), dependency already enforced by a "Fn:GetAtt" at Resources/SumoCWLogsLambda/Properties/Role/Fn::GetAtt
DLQLambdaCloudFormation.yaml:241:9

W3005 Obsolete DependsOn on resource (SumoCWDeadLetterQueue), dependency already enforced by a "Fn:GetAtt" at Resources/SumoCWLogsLambda/Properties/DeadLetterConfig/TargetArn/Fn::GetAtt
DLQLambdaCloudFormation.yaml:242:9

W3005 Obsolete DependsOn on resource (SumoCWLambdaExecutionRole), dependency already enforced by a "Fn:GetAtt" at Resources/SumoCWProcessDLQLambda/Properties/Role/Fn::GetAtt
DLQLambdaCloudFormation.yaml:318:9

W3005 Obsolete DependsOn on resource (SumoCWDeadLetterQueue), dependency already enforced by a "Fn:GetAtt" at Resources/SumoCWProcessDLQLambda/Properties/DeadLetterConfig/TargetArn/Fn::GetAtt
DLQLambdaCloudFormation.yaml:319:9

W3005 Obsolete DependsOn on resource (SumoCWDeadLetterQueue), dependency already enforced by a "Fn:GetAtt" at Resources/SumoCWProcessDLQLambda/Properties/Environment/Variables/TASK_QUEUE_URL/Fn::Join/1/5/Fn::GetAtt
DLQLambdaCloudFormation.yaml:319:9

W3005 Obsolete DependsOn on resource (SumoCWEmailSNSTopic), dependency already enforced by a "Ref" at Resources/SumoCWSpilloverAlarm/Properties/AlarmActions/0/Ref
DLQLambdaCloudFormation.yaml:417:9