search

SumoLogic / sumologic-collector-docker

A Sumo Logic collector for Docker.
Apache License 2.0
69 stars 55 forks source link

Likely accidental use of ENTRYPOINT #76

Open coderanger opened 5 years ago

coderanger commented 5 years ago

The included run.sh is more of a CMD than an ENTRYPOINT given that it doesn't take options or function as a shell.

maimaisie commented 5 years ago

Hi @coderanger thank you for reporting this issue. Do you have any recommendation on how this can be addressed?

coderanger commented 5 years ago

Rather than ENTRYPOINT ["/bin/bash", "/run.sh"], use CMD ["/bin/bash", "/run.sh"]. That sets the default command, rather than the default entrypoint :) They seem similar but work differently inside the container tools.