search

SumoLogic / sumologic-collector-docker

A Sumo Logic collector for Docker.
Apache License 2.0
69 stars 55 forks source link

Allow injection of sources json as an environment variable directly #90

Open Mystik738 opened 4 years ago

Mystik738 commented 4 years ago

Rather than require custom sources.json files to build new images to use (and therefore require users to manage their own images), you should allow JSON to be injected directly as configuration through an environment variable, which, along with volumes, would enable the one image to handle arbitrary configuration.

Mystik738 commented 4 years ago

As an example, I'm handing this in my own repo here: https://github.com/Mystik738/sumologic-collector-docker/commit/c7c7bc579d59c90892dfd7aa14fd2c8021afbf91 but this change would effectively wipe out the need for creating a custom container image and therefore would have a larger documentation change.

I wouldn't mind doing that work, but only if this is an approved feature.