search

SumoLogic / sumologic-collector-puppet-module

Puppet module for installing Sumo Logic's collector.
Other
11 stars 22 forks source link

PR 32 breaks compatibility with older versions of puppet #34

Closed machad closed 6 years ago

machad commented 6 years ago

Pull request 32 merges in data type declarations that are incompatible with old versions of puppet. Some environments are unable to use the latest and greatest versions of puppet, rendering the master branch broken for them (us).

arunpatyal commented 6 years ago

@machad Please share the version of Puppet you have installed?

machad commented 6 years ago

@arunpatyal Version 3.8.7.

arunpatyal commented 6 years ago

@machad Is it ok for you to continue using the older version using the release tag: v0.1.7? https://github.com/SumoLogic/sumo-collector-puppet-module/tree/v0.1.7

machad commented 6 years ago

@arunpatyal We're currently pinned to v0.1.6. Are you officially not supporting 3.8.x anymore?

arunpatyal commented 6 years ago

@machad I am reviewing v0.1.6. Do you have any specific issues or functionalities which should be supported by the v0.1.6 and puppet 3.x compatible version of the module?

arunpatyal commented 6 years ago

@machad I have modified and tested the latest module on puppet 3.8.7. Please review and let me know if you face any issues. The code is available as a release and in the branch v0.1.8 https://github.com/SumoLogic/sumo-collector-puppet-module/tree/v0.1.8

arunpatyal commented 6 years ago

@machad Module back-ported to support puppet 3.8.7. I am closing the issue. Please open a new issue if you have any questions/issues.