search

SumoLogic / sumologic-jenkins-plugin

Apache License 2.0
11 stars 19 forks source link

Upgrade dependencies #50

Closed DuMaM closed 1 year ago

DuMaM commented 2 years ago

Currently Jenkins is migrating to Java 11. This plugin use quite an old one which can lead to problems with stability in newer Jenkins versions. Please update it to latest LTS (2.361.1).

I would be happy if you also add Jenkins plugin bom support (https://github.com/jenkinsci/bom)

Jenkins Google Docs with guide how to upgrade plugin https://docs.google.com/document/d/1PKYIpPlRVGsBqrz0Ob1Cv3cefOZ5j2xtGZdWs27kLuw/edit#heading=h.hvd0nm6pz5o4

DuMaM commented 2 years ago

Also according to install stats: https://stats.jenkins.io/pluginversions/sumologic-publisher.html This plugin can be migrated to at least 2.332.1

sumoanema commented 1 year ago

@DuMaM - We have made the changes for upgrading the jenkins.version to 2.332.1 (with java 8) but we have been facing some issue in deploying the the to jenkins artifactory. If you want to try I can provide you the hpi file privately.

DuMaM commented 1 year ago

There is no rush. Please solve your issues first 😉

sumoanema commented 1 year ago

@DuMaM - I was able to bring the jenkins version to 2.361.4 and introduce bom support as well. This upgrade will now work with java 11 since https://www.jenkins.io/blog/2022/06/28/require-java-11/ .
I have created a PR with these change for which the jenkins ci job seems to be failing because its trying to build it with java 8. Although I have made the changes in JenkinsFile to point to the correct jdk version but somehow it seems to be picking the old JenkinsFile for the jenkins CI job. Have tried multiple times. Here is the PR for the same : https://github.com/jenkinsci/sumologic-publisher-plugin/pull/25/ I am still having a look. Do let me know if you have any idea around this.

DuMaM commented 1 year ago

Ok I left some comments.

sumoanema commented 1 year ago

@DuMaM - I have upgrade the jenkins version and added bom support. There were some access issues and build issues in my mac because of which this item got delayed. Apologies for inconvenience. Could you please try the new plugin from here and let me know if its working fine for you. Also the other issue : https://github.com/SumoLogic/sumologic-jenkins-plugin/issues/49 still persists even after the upgrade and we are looking into it.

DuMaM commented 1 year ago

sorry to say but we switched to other solution and i have to remove this plugin from our Jenkins.

DuMaM commented 1 year ago

https://www.jenkins.io/security/advisory/2023-07-12/#SECURITY-3117