search

SumoLogic / sumologic-log4j2-appender

Log4J 2 Appender for Sumo Logic.
Apache License 2.0
10 stars 10 forks source link

SumoLogicAppenderTest cleanup and new tests for SumoLogicAppender.newBuilder() #52

Closed raphisuter closed 1 year ago

raphisuter commented 1 year ago

I did some small improvements in README.md (add borders/pipe symbols) to all table rows, cleaned up some unnecessary code in SumoLogicAppenderTest and wrote some new tests for the builder of SumoLogicAppender. There were also some occurrences left of hardcoded newLine characters \n in the tests which have been cleaned up as well. (see #51)

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +39.23% :tada:

Comparison is base (a820c53) 38.46% compared to head (de3f65e) 77.69%. Report is 18 commits behind head on master.

:exclamation: Current head de3f65e differs from pull request most recent head d8d0101. Consider uploading reports for the commit d8d0101 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #52 +/- ## ============================================= + Coverage 38.46% 77.69% +39.23% - Complexity 7 10 +3 ============================================= Files 1 1 Lines 130 130 Branches 2 2 ============================================= + Hits 50 101 +51 + Misses 76 27 -49 + Partials 4 2 -2 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/SumoLogic/sumologic-log4j2-appender/pull/52/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SumoLogic)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mccartney commented 1 year ago

Thanks a lot of for this contribution.