Packaging for NLog appender is setting "beta" version for Common

SumoLogic / sumologic-net-appenders

Several appenders for .NET developers to use that send logs straight to SumoLogic.

Apache License 2.0

23 stars 39 forks source link

Packaging for NLog appender is setting "beta" version for Common #62

Closed latkin closed 6 years ago

latkin commented 6 years ago

The NLog appender is currently packed with the following command:

dotnet pack .\SumoLogic.Logging.NLog\SumoLogic.Logging.NLog.csproj --output "$(Convert-Path .)\SumoLogic.Logging.Nuget" --configuration Release /p:Version=$fin_ver-beta1

This appears to be causing the full dependency chain to get tagged with -beta1 package version, including SumoLogic.Logging.Common. The goal is for only the NLog portion to be tagged as beta.

selsig commented 6 years ago

I've not done much nuget packaging but would the following work?

Change pack command to:

dotnet pack .\SumoLogic.Logging.NLog\SumoLogic.Logging.NLog.csproj --output "$(Convert-Path .)\SumoLogic.Logging.Nuget" --configuration Release /p:VersionPrefix=$fin_ver

Change SumoLogic.Logging.NLog.csproj to include:

  <PropertyGroup>
    <VersionSuffix>beta1</VersionSuffix>
  </PropertyGroup>

latkin commented 6 years ago

Seems reasonable. So many magic msbuild properties...

If you can try it out and confirm that it works then I'd be happy to take a PR with that change.