search

SumoLogic / sumologic-otel-collector-packaging

Apache License 2.0
1 stars 3 forks source link

Windows service does not specify LoadOrderGroup #116

Open echlebek opened 3 hours ago

echlebek commented 3 hours ago

The packaging for the Windows collector does not specify DNSClient as part of the LoadOrderGroup (see https://wixtoolset.org/docs/schema/wxs/serviceinstall/#attributes)

It seems that this can lead to the collector not being able to bind to localhost when it starts up, since DNS is not yet available.

While this can likely be worked around by specifying 127.0.0.1 as the bind address, we should make sure the collector does not try to start before DNS is available.

amdprophet commented 2 hours ago

In order to fix this, I think we need to add a ServiceDependency as a child to the existing ServiceInstall element: https://wixtoolset.org/docs/schema/wxs/servicedependency/

The dependency can be a Group; I believe we should be depending on the NetworkProvider group which contains services such as DNS.