SumoLogic / terraform-provider-sumologic

Terraform provider for Sumo Logic
https://www.terraform.io/docs/providers/sumologic/
Mozilla Public License 2.0
40 stars 57 forks source link

feature request: Make authentication and path in sumologic_kinesis_log_source from Required to optional. #523

Open satish4584 opened 1 year ago

satish4584 commented 1 year ago

I was working on AWS Kinesis Firehose for Logs source on sumologic, when i used the sumologic ui, i can create the the source without enabling s3 backup with authentication in place.

image

but when i started converting the same setup into terraform then i realised that sumologic_kinesis_log_source resource from sumo logic provider have authentication and path in the configuration as Required field which doesn't make sense to me. https://registry.terraform.io/providers/SumoLogic/sumologic/latest/docs/resources/kinesis_log_source#authentication

Why do we need two setting for the same purpose when AWS does provide same option from the Amazon Kinesis Data Firehose delivery stream configuration. https://docs.aws.amazon.com/firehose/latest/dev/create-configure.html in below documentation also it says optional but in the provider it's not the same case. https://help.sumologic.com/docs/send-data/hosted-collectors/amazon-aws/aws-kinesis-firehose-logs-source/#set-up-cloudwatch-to-stream-logs-to%C2%A0kinesis-data-firehose

dlinsumo commented 1 year ago

Sumo internal SUMO-221183