search

SumoLogic / terraform-provider-sumologic

Terraform provider for Sumo Logic
https://www.terraform.io/docs/providers/sumologic/
Mozilla Public License 2.0
40 stars 57 forks source link

SUMO-233062: Update the dataType in field resource docs. #648

Closed AyanGhatak closed 6 months ago

AyanGhatak commented 7 months ago

https://api.sumologic.com/docs/#operation/createField

Fields should not include the dataType property during its creation.

AyanGhatak commented 6 months ago

This change can break TF customers. Can we look at DB to find out if customers are using values other than string? We still won't know if they were created via TF but that will a start.

Even though we don't allow sending dataType field in the API, if someone has set Int as the dataType for a field resource, we still get that value in the GET response. So it won't break.

What about API? Are we changing the API too b/c this is a backwards incompatible change.

API has been changed long back. No dataType is not supported for a very long time. We ain't changing the response for an old field, just restricting the same for a new one creation. And swagger endpoints don't mind either for an extra field sent. So updating older fields won't fail as well.

@sumovishal Requesting to re-review

dagould commented 6 months ago

Merged master into this branch to re-trigger build; tfproviderlint succeeded.