Sumukha1496 / maskdata

maskdata is a node.js module to mask various kinds of data
MIT License
92 stars 7 forks source link

Json object replace enhancements and mocha tests #29

Closed sseide closed 11 months ago

sseide commented 2 years ago

I converted all tests from your test.js to mocha and added a lot more for different cases. They can be removed from the test.js now.

Then i updated the mask json method to remove many of the know limitations from the readme:

I added test cases for the new behaviour too.

Can you please check booth PR and merge them creating a new version afterwards?

Thanks in advance, S. Seide

Sumukha1496 commented 2 years ago

Hi @sseide , Thank you for the contribution. I will go through the PR and get back

sseide commented 2 years ago

Hi @Sumukha1496 - do you found some time to review it? I'd like to use this in my project too and need to wait for the official release from you... And there is the other PR #28 open improving a lot of other test cases in mocha and implementing the missing ones from your old test.js

Many thanks