Added an option to memory.js so that outputs can be in a different directory

SunGard-Labs / sg-protractor-tools

This library provides helper functions for the Protractor test framework. It includes functions that simplify things like browser resizing, scrolling and memory usage tracking as part of a test suite.

MIT License

25 stars 6 forks source link

Added an option to memory.js so that outputs can be in a different directory #1

Closed travisgoldie closed 8 years ago

travisgoldie commented 8 years ago

Hey guys,

This is a simple change that will make it a little easier to keep all the output files in a different directory.

Keep up the good work!

Default directory is "./docs/memory"
Used mkdirp prevent any issues with when trying to create the directory

nwinkler commented 8 years ago

Thanks for the contribution, this is great! I've added a couple of comments, please take a look.

Could you also please update the documentation to describe the new dir option?

travisgoldie commented 8 years ago

Comments updated.

Thanks for the feedback. Hopefully others will find it useful!

nwinkler commented 8 years ago

Thanks - I'll take a look at merging and releasing this in the next couple of days.

nwinkler commented 8 years ago

Thanks, this is merged now! I had to merge manually since we work in the develop branch and your PR was against the master branch.

nwinkler commented 8 years ago

Released as part of v1.0.4