PV system layout and cell irradinace input/output via xls

SunPower / PVMismatch

An explicit Python PV system IV & PV curve trace calculator which can also calculate mismatch.

http://sunpower.github.io/PVMismatch/

BSD 3-Clause "New" or "Revised" License

79 stars 30 forks source link

PV system layout and cell irradinace input/output via xls #108

Closed adambgnr closed 5 years ago

adambgnr commented 5 years ago

https://github.com/SunPower/PVMismatch/issues/107

[x] Export pvmm system layout to .xlsx in a human-readable format
[x] Import irradiance and temperature of teh cells from .xlsx files
[x] Add functionality to indicate bypass diode activation
[x] Add functionality to indicate reverse biased cells
[x] Update example_workflow.ipynb

chetan201 commented 5 years ago

thanks @adambgnr for opening this PR, it looks like a valuable addition to contrib. I will happily do a final review after you have had a chance to address @mikofski 's review.

As always, we really appreciate your guidance with PVMismatch @mikofski !

adambgnr commented 5 years ago

Thanks for the reviews so far @mikofski and @chetan201! I have just pushed an update I think I'm halfway there. I have noticed something weird: If I set the cell temperatures high, then the "resolution" of the IV and Power plots made with plotSys() decreases. It can be quite extreme if there are many different cell temperatures in the model: IV_plots_and_temperature I tried to look into why is this happening, but I couldn't find the reason.

mikofski commented 5 years ago

I have noticed something weird: If I set the cell temperatures high, then the "resolution" of the IV and Power plots made with plotSys() decreases.

that's concerning - can you please open an issue? thx

mikofski commented 5 years ago

OK @adambgnr I think #110 is fixed now, but to use it you'll have to pull my gh110_fix_pvsys_resolution branch or wait for @chetan201 to merge it to master and then sync. You can help @chetan201 by reviewing #112 since you're familiar with the issue. @chetan201 do you think you can take a look at it too? Thanks!

adambgnr commented 5 years ago

I think xlsio is ready for final review now. Thanks for the comments so far. Please let me know if something needs improvement. Xlsio depends on Pandas while the core pvmm does not. I didn't add pd to requirements, I guess since xlsio is a contrib, if someone wants to use it they will take care of installing pd themselves, right?

mikofski commented 5 years ago

@adambgnr you should add your name to AUTHORS

adambgnr commented 5 years ago

Thanks @mikofski I added my name and removed a test-function from xlsio, that was just there for me to help learning how to deal with Pipenv.