search

SunPower / PVMismatch

An explicit Python PV system IV & PV curve trace calculator which can also calculate mismatch.
http://sunpower.github.io/PVMismatch/
BSD 3-Clause "New" or "Revised" License
79 stars 30 forks source link

improve cell pattern documentation especially for cross ties #113

Open mikofski opened 5 years ago

mikofski commented 5 years ago

I had to reteach myself what was going on with the cell pattern used for cell_pos because it wasn't immediately obvious to me. The docstring for cell_pos is ok, but a visualization would help more, and the main point is that a "crosstie" refers to the node before the indexed cell to the next column of the module. This means that a crosstie in the last column is meaningless. However, TCT depends on their being crossties for all cells. It also means that crossties across the bottom of the module can't be specified in the cell pattern, but they're assumed. Finally for standard modules with series cells, no crossties should be specified, which is not clear as well. Basically a module with no crossties is assumed to be a standard module.

mikofski commented 4 years ago

The Excel visualizations like in #118 and elsewhere are also useful, maybe these could be automatically created, or something similar