SunPower / PVMismatch

An explicit Python PV system IV & PV curve trace calculator which can also calculate mismatch.
http://sunpower.github.io/PVMismatch/
BSD 3-Clause "New" or "Revised" License
79 stars 30 forks source link

Addressing issue #33 #37

Closed bmeyers closed 8 years ago

bmeyers commented 8 years ago

33 closed

mikofski commented 8 years ago

Can you please make a test? It can be as easy as

from pvmismatch import *

def test_setsuns_fix():
    pvstr = pvstring.PVstring()
    pvstr.setsuns(Ee={3: {8: 0.23, 7: 0.45}})

stick this in pvmismatch/tests folder.

bmeyers commented 8 years ago

Yup, will do

From: Mark Mikofski notifications@github.com Reply-To: SunPower/PVMismatch reply@reply.github.com Date: Sunday, October 9, 2016 at 8:24 PM To: SunPower/PVMismatch PVMismatch@noreply.github.com Cc: Bennet Emil Meyers bennetm@stanford.edu, Author author@noreply.github.com Subject: Re: [SunPower/PVMismatch] Addressing issue #33 (#37)

Can you please make a test? It can be as easy as

from pvmismatch import *

def test_setsuns_fix():

pvstr = pvstring.PVstring()

pvstr.setsuns(Ee={3: {8: 0.23, 7: 0.45}})

stick this in pvmismatch/tests folder.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/SunPower/PVMismatch/pull/37#issuecomment-252532760, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABZTkIEPkgP9yet7tzG1Qd9V8KeSqYiRks5qya_2gaJpZM4KQvqr.

bmeyers commented 8 years ago

@mikofski Done!