Futurize - Githubissues

SunPower / PVMismatch

An explicit Python PV system IV & PV curve trace calculator which can also calculate mismatch.

http://sunpower.github.io/PVMismatch/

BSD 3-Clause "New" or "Revised" License

79 stars 30 forks source link

Futurize #54

Closed mikofski closed 6 years ago

mikofski commented 6 years ago

updating PVMismatch for Python 3 using future and six compatibility packages

all tests are passing in both Python-2.7 and Python-3.6 except test_two_diode.py:test_didv_dpdv_frsh() on line 63 which has an issue with SymPy converting an expression to float, so I'll add an issue to fix it

TypeError: can't convert expression to float

mikofski commented 6 years ago

merging #56 fixes #55 so all tests are now passing for both Python-2.7 and Python-3.6, at least on my machine

mikofski commented 6 years ago

@chetan201 I think this is ready

mikofski commented 6 years ago

@chetan201 dulwich and pvlib now on conda-forge so you can install everything into your conda environment in one go:

conda create -n pvmismatch python==3.6.3 -c conda-forge --file requirements.txt

mikofski commented 6 years ago

@chetan201 just wondering, if you don't have time for this, perhaps you can consider some alternatives:

isn't @bmeyers a collaborator? does he have write access? he could probably review and merge this PR and #56
would you and @BenBourne consider moving this to the @pvlib organization, if @wholmgren agrees to it?

chetan201 commented 6 years ago

@mikofski I spent last few days getting familiar with the repo and such. I would like to sync up with @BenBourne and get to close this very soon. Apologies for the delays!

chetan201 commented 6 years ago

Actually, it doesn't seem that I have write access to do a merge here. Any advice on how to get that? Thanks!

mikofski commented 6 years ago

ask either @trevorhodges or @rickmellor , they are the SP GitHub owners

cedricleroy commented 6 years ago

@chetan201, you now have write access to this repo.

chetan201 commented 6 years ago

Thanks @cedricleroy and @mikofski for the help! This PR is merged now.