search

SunPower / PVMismatch

An explicit Python PV system IV & PV curve trace calculator which can also calculate mismatch.
http://sunpower.github.io/PVMismatch/
BSD 3-Clause "New" or "Revised" License
79 stars 30 forks source link

band gap is not variable in contrib.gen_coeffs() #57

Open mikofski opened 6 years ago

mikofski commented 6 years ago

The band gap, Eg, is constant in diode.py line 10 but different tech would have a different band gap so it should be a variable.

markcampanelli commented 6 years ago

I agree. I fit this parameter from a collection of IV curves in my parameter fitting software. Whether this fit values is physically meaningful vs. completely confounded is another another story ;).

mikofski commented 6 years ago

Thanks @thunderfish24 would you be will to contribute something to the contrib.gen_coeffs package ?

markcampanelli commented 6 years ago

If I could get compensated for the initial effort to make my diode fitting public domain, then I would strongly consider it. 🙂

On Wed, Jan 10, 2018 at 13:09 Mark Mikofski notifications@github.com wrote:

Thanks @thunderfish24 https://github.com/thunderfish24 would you be will to contribute something to the contrib.gen_coeffs package http://../tree/master/pvmismatch/contrib/gen_coeffs ?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/SunPower/PVMismatch/issues/57#issuecomment-356704759, or mute the thread https://github.com/notifications/unsubscribe-auth/ABEr83JASklqov9VZN7QdyxMpv6N51mlks5tJQrRgaJpZM4RZngW .