Your monthly subscription of code review - Githubissues

SunResearchInstitute / SwitchPresence-Rewritten

Nintendo Switch sysmodule server for PresenceClient!

https://link.sunthecourier.net/switchpresence

GNU General Public License v2.0

126 stars 15 forks source link

Your monthly subscription of code review #39

Closed cathery closed 4 years ago

cathery commented 4 years ago

GUI Client: Fixed an issue causing the app to randomly timeout on displaying a game until a game is changed.
GUI Client: Fixed an issue causing the client to close if it can't find the appropriate MAC address in the network.
GUI Client: Increased connection timeout from 15 to 60 seconds
Sysmodule: Increased refresh rate from 5 seconds to 1 second
Sysmodule: Reduced heap size to 0x6000 bytes

Internal changes:

All naming instances of tid/pid have been changed to a consistent programId
GUI Client: checking for changed games is now done by comparing programId's instead of comparing their names
Sysmodule: hidden all the implementation of socket connection inside its source file
Sysmodule: main thread stack size reduced from 0x3000 to 0x1000 bytes