search

SunSpecOrangeButton / pyoblib

Orange Button Python Library
Apache License 2.0
14 stars 19 forks source link

Updated from_JSON to use newest XBRL JSON specification to address #77 #110

Closed joelebwf closed 5 years ago

joelebwf commented 5 years ago

Please note that from_JSON now will import JSON that is in the XBRL specification or JSON that is created by to_JSON. It does not necessarily enforce the data types required by the specification correctly. Conversations are still underway with both XBRL and Jono exactly what is correct in this regards.

codecov-io commented 5 years ago

Codecov Report

Merging #110 into master will decrease coverage by 1%. The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   88.63%   87.62%   -1.01%     
==========================================
  Files          23       23              
  Lines        2296     2303       +7     
==========================================
- Hits         2035     2018      -17     
- Misses        261      285      +24
Impacted Files Coverage Δ
oblib/tests/test_parser.py 100% <ø> (ø) :arrow_up:
oblib/tests/test_json_clips.py 90.9% <ø> (-9.1%) :arrow_down:
oblib/parser.py 68.92% <72.22%> (-6.17%) :arrow_down:
oblib/util.py 88.88% <0%> (-11.12%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8765897...e403ad5. Read the comment docs.