search

SunSpecOrangeButton / pyoblib

Orange Button Python Library
Apache License 2.0
14 stars 19 forks source link

Updated docstrings and variable names to address #75 and #86 #114

Closed joelebwf closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #114 into master will not change coverage. The diff coverage is 98%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files          23       23           
  Lines        2303     2303           
=======================================
  Hits         2018     2018           
  Misses        285      285
Impacted Files Coverage Δ
oblib/identifier.py 100% <ø> (ø) :arrow_up:
oblib/tests/test_taxonomy.py 100% <100%> (ø) :arrow_up:
oblib/taxonomy.py 94.93% <100%> (ø) :arrow_up:
oblib/taxonomy_types.py 97.87% <100%> (ø) :arrow_up:
oblib/tests/test_taxonomy_semantic.py 100% <100%> (ø) :arrow_up:
oblib/taxonomy_misc.py 99.28% <100%> (ø) :arrow_up:
oblib/tests/test_validator.py 98.41% <100%> (ø) :arrow_up:
oblib/taxonomy_units.py 80.16% <100%> (ø) :arrow_up:
oblib/util.py 88.88% <100%> (ø) :arrow_up:
oblib/parser.py 68.92% <94.73%> (ø) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e2d0db...3ebca13. Read the comment docs.

cwhanse commented 5 years ago

docstring patterns look OK to me. I skimmed the changes and don't see anything I'd change. I'm approving here with that caveat that I didn't do a careful review.