search

SunSpecOrangeButton / pyoblib

Orange Button Python Library
Apache License 2.0
14 stars 19 forks source link

Fixes for issues #60 #92 #142 and #144 #155

Closed jonoxia closed 5 years ago

jonoxia commented 5 years ago

60 : replaced OBException and subclasses with OBError and subclasses in data_model.

92 : renamed data_model.OBInstance.validate_context() to _is_valid_context().

142 : forced fact values of true, false, and null to be exported to JSON as true/false/null literals, all other values to be strings.

144 : Removed special-case code from data_model that was used to create 'All' entrypoint by combining other entrypoints. Made taxonomy_semantic create 'All' entrypoint by reading core/solar_all_2018-03-31_r01_def.xml instead.

codecov-io commented 5 years ago

Codecov Report

Merging #155 into master will increase coverage by 0.33%. The diff coverage is 89.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   90.28%   90.62%   +0.33%     
==========================================
  Files          25       25              
  Lines        2461     2463       +2     
==========================================
+ Hits         2222     2232      +10     
+ Misses        239      231       -8
Impacted Files Coverage Δ
oblib/taxonomy_semantic.py 98.3% <100%> (+0.01%) :arrow_up:
oblib/tests/test_data_model.py 99.5% <100%> (+0.02%) :arrow_up:
oblib/tests/test_taxonomy_semantic.py 100% <100%> (ø) :arrow_up:
oblib/parser.py 73.23% <100%> (+0.2%) :arrow_up:
oblib/data_model.py 80.49% <72.5%> (+0.69%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1eb3dbe...f8d70fa. Read the comment docs.