search

SunSpecOrangeButton / pyoblib

Orange Button Python Library
Apache License 2.0
14 stars 19 forks source link

Remove hardcoded taxonomy urls #170

Closed cwhanse closed 5 years ago

cwhanse commented 5 years ago

Perhaps move the URLs to constants.py as a dict, to collect them in a single place. As is, versions of pyoblib are tied to specific releases of the solar (and other) taxonomies.

A possible alternative is to make use of Arelle's taxonomy discovery capabilities.

joelebwf commented 5 years ago

I think there is more to this than just moving constants to a single place (although perhaps this is a good start). We need to also decide what to do when the namespace versions don't line up with the current code - i.e. do we just try to process input and hope for the best or throw an exception? I will add it to 1.1.0 because this is a reasonable time to address this.