search

Sunagatov / Iced-Latte

a online Marketplace for coffee retail (Backend)
https://iced-latte.uk
MIT License
610 stars 115 forks source link

GET product reviews request with an invalid value of param "size" the system returns all product reviews #328

Open TetianaPerinha opened 5 months ago

TetianaPerinha commented 5 months ago

Describe the bug When sending a GET product reviews request with an invalid value of param "size" the system returns all product reviews

To Reproduce Send the GET request as below use value for param size = %, +

curl --location '[https://iced-latte.uk/backend/api/v1/products/e6a4d7f2-d40e-4e5f-93b8-5d56ce6724c5/reviews?page={value}](https://iced-latte.uk/backend/api/v1/products/e6a4d7f2-d40e-4e5f-93b8-5d56ce6724c5/reviews?size={value}

Expected behavior The system should reject the request with 400 HTTP Status code "error": "Bad Request".

Actual result System accept the request and returns all product reviews.

get all reviews with param size = % get all reviews with param size = +
Prankurtiwari commented 3 months ago

Hi @TetianaPerinha Please assign this bug to me and I will start working on this.

Prankurtiwari commented 3 months ago

Issue fixed in this PR. Please review

TetianaPerinha commented 3 months ago

Issue fixed in this PR. Please review

@Sunagatov Review please

Prankurtiwari commented 2 months ago

Issue fixed in this PR. Please review

@Sunagatov Review please

Can you please review and approve the PR for merge.

Prankurtiwari commented 2 months ago

@TetianaPerinha / @Sunagatov Any update guys on this PR. It been hanging there for more than two months. Do you have any review comment ?