search

Sunagatov / Iced-Latte

a online Marketplace for coffee retail (Backend)
https://iced-latte.uk
MIT License
587 stars 95 forks source link

GET product reviews request with an invalid value of param "product_rating" the system returns all product reviews #329

Open TetianaPerinha opened 1 week ago

TetianaPerinha commented 1 week ago

Describe the bug When sending a GET product reviews request with an invalid value of param "product_rating" the system returns all product reviews

To Reproduce Send the GET request as below use value for param product_rating = %

curl --location '[https://iced-latte.uk/backend/api/v1/products/e6a4d7f2-d40e-4e5f-93b8-5d56ce6724c5/reviews?page={value}]([https://iced-latte.uk/backend/api/v1/products/e6a4d7f2-d40e-4e5f-93b8-5d56ce6724c5/reviews?size={value}](https://iced-latte.uk/backend/api/v1/products/e6a4d7f2-d40e-4e5f-93b8-5d56ce6724c5/reviews?product_rating={value}

Expected behavior The system should reject the request with 400 HTTP Status code "error": "Bad Request".

Actual result System accept the request and returns all product reviews.

get all reviews with param product_ratings = %
Prankurtiwari commented 1 week ago

Hi TetianaPerinha, Can you assign this issue to me ??? Or is it okay if i start working on this ?? Please let me know in any case. TBH I am contributing to Open Source for the first time so I am unaware of the protocols.

Prankurtiwari commented 5 days ago

Hi TetianaPerinha, I have raised the initial PR. Please review