Sms provider configuraton

Sunbird-Lern / sunbird-auth

Repository for sunbird authentication service

MIT License

7 stars 59 forks source link

Closed shriharshs closed 6 years ago

shriharshs commented 6 years ago

This will capture all the sms provider configurations.

coolbung commented 6 years ago

Some high level feedback

The provider / factory implementation should ensure that adding a new SMS provider should only involve creating a provider and factory (and a config file)
At the most you could add the provider name to some file to "register" it
No changes to be made to any other classes
NEVER check in credentials into GIT

More feedback inline

shriharshs commented 6 years ago

@kochhar Sure

shriharshs commented 6 years ago

@kochhar @coolbung Refactored the changes suggested. Please take a look.

kochhar commented 6 years ago

@shriharshs @coolbung merging this PR.