search

Sunbird-Lern / sunbird-auth

Repository for sunbird authentication service
MIT License
7 stars 59 forks source link

Issue #7 feat: SMS OTP Reset flow provider #8

Closed shriharshs closed 6 years ago

shriharshs commented 6 years ago

PR for SMS OTP Authentication of Forgot password reset credentials flow

coolbung commented 6 years ago

Can you put the provider folder inside the keycloak folder.

shriharshs commented 6 years ago

@coolbung - I think its better be out, because it might confuse with the themes folder of keycloak, and this folder you can easily be imported as a project in IDE.

coolbung commented 6 years ago

I was thinking to mimic the folder structure when keycloak gets deployed. Or is that not useful ?

cc @kochhar

kochhar commented 6 years ago

@coolbung @shriharshs would be good to put this inside a keycloak folder. There may be other auth utilities unrelated to keycloak in this repo.

/keycloak/sms-provider/src/... can be the directory imported into an IDE.

shriharshs commented 6 years ago

@kochhar Other than test cases, other changes are done! :)

shriharshs commented 6 years ago

@kochhar Created test case stubs.