Code refactoring for Emission Data Storage - Githubissues

Sunbird-cQube / community

Community repo for cQube where documentation, discussions, etc are enabled.

MIT License

3 stars 7 forks source link

Code refactoring for Emission Data Storage #524

Closed satendrapalsingh closed 1 year ago

satendrapalsingh commented 2 years ago

[ ] 01. Code Structure The code structure is not consistent with sunbird standards. I expected a basic organisation of the code into ingestion, processing, storage, metrics, query etc folders. Please review this in detail with Anand P.

Update Folder sructure is organised. Require inputs and then review. https://github.com/Sunbird-cQube/cQube_Edu/tree/cqube-4.0-alpha

[ ] 02. Code Readability With respect to code, I see function names becoming the file names themselves. for ex: update_nifi_params.py etc. Readability of the code is poor and this would have a significant impact on maintainability and contribution. Code needs to be refactored as well, please plan for it post review with Anand P

Additional Info

Python script https://github.com/Sunbird-cQube/cQube_Workflow/blob/release-3.7/development/datasource/python/views.py
The Diskha data extraction mechanism is implemented through the NIFI processor.

Update Code refactor is partially done, Require input and then review https://github.com/Sunbird-cQube/cQube_Edu/tree/cqube-4.0-alpha/utils/nifi-utils

RNarmatha commented 1 year ago

It is completed