Compass to inquiry pr - Githubissues

pavankumar0408 commented 11 months ago

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please choose appropriate options.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Ran Test A
[ ] Ran Test B

Test Configuration:

Software versions:
Hardware versions:

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

pavankumar0408 commented 11 months ago

-> Added changes for allowing user to select server side evaluation or client side evaluation of the test. -> If creator has been selected 'server', test evaluation will happen at server side and questions that are added will be evaluated at server side in player. No answer will be shown at client side. -> If creator has been selected 'client', test evaluation will happen at client side and questions that are added will be evaluated at client side in player(Which is existing flow)

rajnishdargan commented 11 months ago

@pavankumar0408 Don't we have JIRA ticket for the feature? Jira description action is failing, the PR title should be in the below format Issue #IQ-xxx feat: Proper message for PR header or the Jira ticket title

rajnishdargan commented 11 months ago

@pavankumar0408 SonarCloud Quality Gate is failing 1 Bug and 2 code smells is getting detected. Could you please fix it. Please improve the code coverage to 80% in the PR.

rajnishdargan commented 11 months ago

@pavankumar0408 Please change the package version to "version": "7.0.0-beta.0" here:- https://github.com/Sunbird-inQuiry/editor/blob/main/projects/questionset-editor-library/package.json#L3

Also the web-component version is to be upgraded after building the web component using the command npm run build-web-component For reference - https://github.com/Sunbird-inQuiry/editor/commit/723e56414e1b938557437ebd5e967e743ac23b0e

Note: Make sure the web component is working fine. For running the web component hit the localhost:3000 in browser while running server.js file.

pavankumar0408 commented 11 months ago

@rajnishdargan @sajeshkayyath , review comments have been fixed. Test cases have been added for written code.

Please provide access for adding reviewers also please let me know the jira link where can I create ticket for this.

pavankumar0408 commented 11 months ago

@rajnishdargan @sajeshkayyath have added few more test cases its improved in PR.

Note: In local the code has been covered but here in sonar cloud code is not covered. How to check this

pavankumar0408 commented 11 months ago

@rajnishdargan @sajeshkayyath , I am finding difficulty in covering these 5 lines but while taking average of these coverages I am getting more than 80%. In sonarcloud it is showing 69%. Please allow this PR to get merge if this can be exceptional case.

rajnishdargan commented 11 months ago

@pavankumar0408 Please update @project-sunbird/sunbird-quml-player-web-component to 3.0.0-beta.0 and @project-sunbird/sunbird-resource-library to 7.0.0-beta.0

pavankumar0408 commented 11 months ago

@rajnishdargan , packages have updated cc @sajeshkayyath

rajnishdargan commented 11 months ago

@pavankumar0408 Please build the web component once again and push the changes of sunbird-questionset-editor.js in the PR

pavankumar0408 commented 11 months ago

@rajnishdargan, build done and pushed the changes