Closed ramkumar-pacewisdom closed 6 months ago
rajnishdargan
commented
6 months ago Hey @ramkumar-pacewisdom, Sonar Cloud Analysis isn't working properly. Can you fix it? Also, before we begin the review, I'm curious about the testing in the Dock environment. Are we testing just the changes for Observation and Survery or also the existing flows like Practice Question Sets and Exam Question Sets?
ramkumar-pacewisdom
commented
6 months ago Hey @ramkumar-pacewisdom, Sonar Cloud Analysis isn't working properly. Can you fix it? Also, before we begin the review, I'm curious about the testing in the Dock environment. Are we testing just the changes for Observation and Survery or also the existing flows like Practice Question Sets and Exam Question Sets?
@rajnishdargan it has only 3 lines of code changes in updated commit, because of that it's showing less than 50% code coverage, in overall it's above 80%, That's why i raised as PR. Please share your comments about this.
sonarcloud[bot]
commented
6 months ago 
Quality Gate passedIssues
6 New issues
Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code
In this PR changes added for Reviewer flow in Observation and survey, Reference links added below Ticket Link : https://project-sunbird.atlassian.net/browse/IQ-125 Figma Link : https://www.figma.com/proto/yxiLGMrnYICNnm5wZSrEFd/Observation-creation-Review-flow?page-id=0%3A1&type=design&node-id=33-18&viewport=561%2C337%2C0.19&scaling=scale-down&starting-point-node-id=33%3A18