search

Sunconure11 / dungeon-mobs

Dungeon Mobs
Other
7 stars 1 forks source link

Mobs Spawning Anywhere? (I.e., at any elivation, reguardless of setting) #31

Open BlackJar72 opened 5 years ago

BlackJar72 commented 5 years ago

It has been reported that the mobs are now spawning anywhere, regardless of config. I have not observed it directly, but if so it needs to be addressed. This is only said to be a problem with the latest version (version 5.5.0). But currently, when combined with some (unknown) mods altitude restrictions and the need to see sky disappear.

Sunconure11 commented 5 years ago

Has this been dealt with? Just so I know, so I can close this.

Also, if you want, you can take a look at my own mod and try to work it's spawn system into this mod.

https://github.com/Um-Mitternacht/Bewitchment

BlackJar72 commented 5 years ago

I'm not sure what to do to deal with it -- I can't duplicate it. MohawkyMagoo reported it, and I wonder if another mod is causing it. As far as I can tell it was never a problem, at least not a problem with this mod.

https://www.minecraftforum.net/forums/mapping-and-modding-java-edition/minecraft-mods/2911910-dungeon-mobs-theyre-back#c5

Maybe I can look into some of this next month, if I find time. I'm very close to basically "retiring" from modding -- I'm still unsure if I'll finish the re-write of climatic biome. I find it harder and harder to be motivated to work on mods as I play the game less and less, and see other things I'd rather do with my time. I'm not even sure if there will be doomlike dungeons for 1.13+ if the new multithreaded world-gen make updating non-trivial. There are reason I decided I didn't really want to "own" this.

Sunconure11 commented 5 years ago

https://github.com/Um-Mitternacht/Bewitchment/blob/d17dc91eeeb4aa25612b62abb5edfc7da5b2fff5/src/main/java/com/bewitchment/common/entity/ModEntities.java

BlackJar72 commented 5 years ago

I don't get it -- what am I looking at and what am I supposed to do with it.

Sunconure11 commented 5 years ago

Try and rework it based on this. I'm currently too busy with another mod to do much here.

Sunconure11 commented 5 years ago

Also, that code tells where the mobs are supposed to spawn, based on biomedict definitions. @zabi94

BlackJar72 commented 5 years ago

I actually don't see the advantage -- it does the same thing, basically.

I suppose if a biome limit were added in the configs that could be added. Biome limits don't make sense to me for a mod like this, where mobs are sorted vertically, but I guess some would like to redefine what it's about. Until when / if such a config exists I don't see a need for a change, and at such a time it would only be an addition to theregisterSpawns() method. Again I don't see the point, or how this has do do with this particular issue.

BlackJar72 commented 5 years ago

It reported that at least one player (Mohawky Magoo) is still having this problem. I'm at a loss so I'm listing it as "help wanted."